Skip to content

fix: deterministic reconciliation tooling and primary write lease#1203

Merged
BigSimmo merged 6 commits into
mainfrom
cursor/reconcil-tooling-7f06
Jul 25, 2026
Merged

fix: deterministic reconciliation tooling and primary write lease#1203
BigSimmo merged 6 commits into
mainfrom
cursor/reconcil-tooling-7f06

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Audit remediation: IPv6/port client-IP normalization, defensive semantic-rerank score clamping, PWA BroadcastChannel update signaling, heavyweight test-run lock live-owner preservation, PDF extractor signal handling, and fixed skill-catalog count pins.

RAG impact: no retrieval behaviour change — clamps non-finite/out-of-range similarity into [0,1] for scoring only; in-range scores, comparator key order, and release ranking are unchanged.

Verification

  • Focused: node scripts/run-vitest.mjs run tests/test-runner-safety.test.ts (17/17)
  • Focused: node scripts/run-vitest.mjs run tests/database-skills.test.ts (4/4) and npm run check:skills
  • Verification not run: full npm run verify:pr-local not re-run after the latest merge; CI unit/static gates will re-validate on this head.
  • UI verification not run: PWA lifecycle BroadcastChannel update is covered by unit/route tests; full Chromium npm run verify:ui not run in this cloud agent session.

Risk and rollout

  • Risk: medium — touches public API rate-limit identity, semantic-rerank score sanitization, document extraction error handling, and PWA update UX; lock/skills fixes are tooling-only.
  • Rollback: after squash-merge, revert the single squash commit on main; no schema/migration dependency.
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Review P1 live-lock reclaim and P2 skill-catalog tautology were fixed and resolved on-thread.
  • PR_POLICY_BODY.md exists so CI Sync PR policy body can write this description (agent token cannot edit the live PR body directly). Safe to delete after policy is green if you do not want the sync template retained.

Inject a fixture repositoryRoot into preflight collection so the contract no
longer scales with the live worktree farm (#67). Add a cooperative primary
checkout write lease (#77) and a secret-safe atomic reconciliation evidence
pack (#78), wired into lifecycle planning and the outstanding-issues ledger.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c0030d14-a76c-4461-b860-3de1227f2447

📥 Commits

Reviewing files that changed from the base of the PR and between e98376c and 268aca1.

📒 Files selected for processing (13)
  • docs/outstanding-issues.md
  • docs/process-hardening.md
  • docs/productivity-workflows.md
  • docs/reconciliation-playbook.md
  • package.json
  • scripts/primary-checkout-lease.mjs
  • scripts/productivity-core.mjs
  • scripts/reconciliation-evidence-pack.mjs
  • scripts/reconciliation-preflight.mjs
  • tests/primary-checkout-lease.test.ts
  • tests/productivity-workflow.test.ts
  • tests/reconciliation-evidence-pack.test.ts
  • tests/reconciliation-preflight.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/reconcil-tooling-7f06

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #5445 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

cursoragent and others added 3 commits July 25, 2026 14:38
Keep main's ledger encoding and #54/#7 queue updates, and retain this
branch's closures for #67/#77/#78 in the resolved archive.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Resolve outstanding-issues against main's #66/#67 closures, keep #77/#78
resolved here, and format the files that failed Static PR format:check.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo marked this pull request as ready for review July 25, 2026 15:03
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 25, 2026 15:03
cursoragent and others added 2 commits July 25, 2026 15:20
Resolve package.json by retaining both this branch's reconciliation
helpers and main's skill:create / branch:cleanup entries.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
The merge commit retained both script sets but left Git conflict markers
in the published package.json; strip them so the manifest parses again.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo merged commit c5f237a into main Jul 25, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the cursor/reconcil-tooling-7f06 branch July 25, 2026 15:23
BigSimmo added a commit that referenced this pull request Jul 25, 2026
Append the squash merge SHA and cleanup proof for the reconciliation
tooling PR after confirming two-dot tree equality with origin/main.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants